1. Conventional War: Pakistan
2. Nuclear War: Pakistan obviously as Iran doesn't have nukes
Pakistan holds pretty much every advantage. More than double the population, vastly superior air force, much better tanks, artillery and Pakistan could expect support from the USA, China, Saudi Arabia...